Discussing the Use and Modification of Helm Charts

Shivanshu

Hey Paul, Steve, eg look at and the value is coming from , similarly And the same thing is happening for all the other components. BUT this serves the purpose, since, once the helm charts are rendered, it creates the k8s objects and the images are pulled from respective registries. (, , etc) Even if we modify the charts to default to global registry (if set) you won't be able to use `--set global.image.registry=""` until unless you have a copy of all the images in the specified global registry (`` in this case) Note: `--set global.image.registry=""` is for performing a pull operation not push

Srikanth

> Hey Paul, Steve, > no, the current helm charts are pretty much hardcoded. What Steve said works. The “hardcoded” values are not hardcoded but default. The registry name can always be overrided by `--set global.imageRegistry=...` .

Shivanshu

Correct, but can it be used for pulling the container images? > I trying to change de registry of all containers using helm with the parameter: `--set global.image.registry=""` AFAIU, here the ask is if the registry can be changed for `all containers`, but the answer is no, the rendered deployments are not referring to `global.image.registry` in values.yaml

Shivanshu

though individual images can be tweaked as mentioned in the

Srikanth

Shivanshu

this has no effect since the global value defined here is not referenced anywhere in the charts.

Srikanth

Shivanshu

I was referring to

Shivanshu

and `_helpers.tpl` does not contain a global default for `.Values.otelCollector.image`

Shivanshu

but yes, it contains for others

Shivanshu

`otelCollector.image` is the missing case, right?

Srikanth

Yeah, probably some places were missed, would you mind creating an issue in the charts repo?

Shivanshu

Sure, thanks for bearing up with me

Shivanshu

filed an issue here

Srikanth

thanks

Steve

it seems like we are looking a different charts. The one I pulled from does have an entry in _helpers.tpl file defining the template symbol that is actually used in the otel-collector deployment.yaml

Steve

{{- define "otelCollector.image" -}} {{- $registryName := default .Values.otelCollector.image.registry .Values.global.imageRegistry -}} {{- $repositoryName := .Values.otelCollector.image.repository -}} {{- $tag := .Values.otelCollector.image.tag | toString -}} {{- if $registryName -}} {{- printf "%s/%s:%s" $registryName $repositoryName $tag -}} {{- else -}} {{- printf "%s:%s" $repositoryName $tag -}} {{- end -}} {{- end -}}