#general

Issues and Changes in OpentelemetryJs

TLDR Harald expressed frustration about changes and documentation issues in OpentelemetryJs. Srikanth shared the upgrade guidelines and suggested contributing to improve the project. Harald agreed to create a new PR for SigNoz examples.

Powered by Struct AI
+11
26
6mo
Solved
Join the chat
Mar 17, 2023 (6 months ago)
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
02:04 PM
OpentelemetryJs has changed - I make a new PR for the SigNoz examples and add some words of wisdom to it.
Ankit
Photo of md5-dbe7088320fe1d922707613e02f3420d
Ankit
02:07 PM
that would be helpful
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
02:08 PM
They changed the npm namespaces 10+ times - on npm there are still the old packages (just a warning, but nothing how/where/what to change)
02:08
Harald
02:08 PM
this is sick
Srikanth
Photo of md5-ce04a9988e2fd758a659dc55be6f2543
Srikanth
02:52 PM
It is still an evolving project and they should keep the old packages because someone might still be using them, this is done by every language group.
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
03:27 PM
That's not my point.
03:27
Harald
03:27 PM
The point is - the direction "please got to place X, replace A with B, include C, drop D" - that is 1000% missing.
03:28
Harald
03:28 PM
It took me one day to find that out and make an working example from the - broken - opentelemetry.JS example. Sorry - that's bad.
Srikanth
Photo of md5-ce04a9988e2fd758a659dc55be6f2543
Srikanth
03:32 PM
They publish upgrade guidelines https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines. While we don’t have control over that, we can get our examples up to date. Would really appreciate your contribution PR or just share the outdated repo or docs and we shall get it updated.
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
03:33 PM
Yes 🙂 they are 1000% useless
Srikanth
Photo of md5-ce04a9988e2fd758a659dc55be6f2543
Srikanth
03:34 PM
That’s harsh, if you think you could suggest something that makes it useful you can suggest and contribute to opentelemetry-js.
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
03:34 PM
Bad documentation is even worse then no documentation. Other npm projects (hey - it's npm!) get their sunsetting of an old package right - while opentelemetry didn't.
03:36
Harald
03:36 PM
"Please use X"
03:37
Harald
03:37 PM
(but what I didn't tell you - you need to - also replace x with y and use Class A instead of B. I don't tell you that in our upgradeguidelines, and I only put a broken example "somewhere" even didn't mentioning that we replaced npm packages)
03:37
Harald
03:37 PM
still to harsh?
03:38
Harald
03:38 PM
also bound instruments are gone (or might work totally different - I didn't find this out after one day)
Srikanth
Photo of md5-ce04a9988e2fd758a659dc55be6f2543
Srikanth
03:43 PM
Let’s not argue over this and end it here; I get your frustration but there is another side to it. And we would really appreciate it if you can send a PR to update the SigNoz example or share which guide or repo you are referring following.
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
03:44 PM
It's me ranting about Opentelemetry JS not about SigNoz 🙂
Srikanth
Photo of md5-ce04a9988e2fd758a659dc55be6f2543
Srikanth
03:45 PM
I understand and I am saying there is other side to it because I help a sub project (opentelemetry-python) and I know fellow maintainers struggles.
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
03:45 PM
Fun Fact. NodeJS killed the DDog Metrics library 1/2 year ago. DDog updated it - we didn't 😂
03:46
Harald
03:46 PM
it was a tiny something about something with a Promise NodeJS changed and that broke the JS
Srikanth
Photo of md5-ce04a9988e2fd758a659dc55be6f2543
Srikanth
04:30 PM
Thank you
Harald
Photo of md5-01b4600434aa419becd17a9f7773e2ff
Harald
04:30 PM
I squashed them - tell me if you need 3 PRs
Srikanth
Photo of md5-ce04a9988e2fd758a659dc55be6f2543
Srikanth
04:31 PM
One is fine
+11